Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve BackupReady conditions #618

Open
Tracked by #702
shreyas-s-rao opened this issue Jun 17, 2023 · 2 comments
Open
Tracked by #702

[Enhancement] Improve BackupReady conditions #618

shreyas-s-rao opened this issue Jun 17, 2023 · 2 comments
Assignees
Labels
area/backup Backup related kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age)

Comments

@shreyas-s-rao
Copy link
Contributor

shreyas-s-rao commented Jun 17, 2023

Feature (What you would like to be added):
Enhance BackupReady conditions to provide more meaningful messages and reasons for setting different BackupReady conditions.

Motivation (Why is this needed?):
Currently not all combinations of full and delta snapshot lease renewal times are handled by custodian controller.

Approach/Hint to the implement solution (optional):
Add additional field state to EtcdMember.status.snapshots.lastFull and EtcdMember.status.snapshots.lastDelta, in order to allow the etcd member to correctly publish snapshot state information, which druid will use to accurately populate the BackupReady condition, as described in #619 (comment)

@shreyas-s-rao shreyas-s-rao added area/backup Backup related kind/enhancement Enhancement, improvement, extension labels Jun 17, 2023
@shreyas-s-rao
Copy link
Contributor Author

/assign

@plkokanov
Copy link
Contributor

We could also improve the BackupReady condition by providing additional information (either via logs or the conditions messages field) when it's status is Unknwon ref: #732

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backup Backup related kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants