Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safety check as a part of data validation, to check the etcd data directory revision is greater than last snapshot revision #67

Closed
swapnilgm opened this issue Nov 19, 2018 · 0 comments · Fixed by #85
Closed

Add safety check as a part of data validation, to check the etcd data directory revision is greater than last snapshot revision #67

swapnilgm opened this issue Nov 19, 2018 · 0 comments · Fixed by #85
Assignees
@shreyas-s-rao
Labels
area/robustness Robustness, reliability, resilience related effort/1d Effort for issue is around 1 day exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension platform/all
Milestone
---

Comments

@swapnilgm
Copy link
Contributor

To just to make sure that, that Etcd data directory is in consistent shape across the restart of backup-sidecar or etcd containe and there is no data loss, we should add a sanity check such that, etcd data directory revision is always greater than equal to latest snapshot.
@swapnilgm swapnilgm added kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) exp/intermediate Issue that requires some project experience platform/all area/robustness Robustness, reliability, resilience related labels Nov 22, 2018
@georgekuruvillak georgekuruvillak mentioned this issue Nov 28, 2018
Closed
@swapnilgm swapnilgm added this to the 0.5.0 milestone Dec 5, 2018
@shreyas-s-rao shreyas-s-rao mentioned this issue Dec 12, 2018
Merged
@PadmaB PadmaB modified the milestones: 0.5.0, --- Jan 23, 2019
@gardener-robot gardener-robot added effort/1d Effort for issue is around 1 day and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shreyas-s-rao shreyas-s-rao

Labels
area/robustness Robustness, reliability, resilience related effort/1d Effort for issue is around 1 day exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension platform/all
Projects
None yet
Milestone
---
Development

Successfully merging a pull request may close this issue.

Add sanity check for revision numbers shreyas-s-rao/etcd-backup-restore
4 participants
@PadmaB @swapnilgm @shreyas-s-rao @gardener-robot