Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Flatten directory structure of backup store of ETCD BR #308

Closed
abdasgupta opened this issue Feb 24, 2021 · 1 comment
Closed
Labels
kind/enhancement Enhancement, improvement, extension
Milestone

Comments

@abdasgupta
Copy link
Contributor

abdasgupta commented Feb 24, 2021

Currently, directory structure of ETCD backup is like the following:
Current Directory Structure

v1
  - Backup-192345
      - Full-Snapshot-192345
      - Incremental-Snapshot-192355
      - Incremental-Snapshot-192365
      - Incremental-Snapshot-192375
  - Backup-192789
      - Full-Snapshot-192789
      - Incremental-Snapshot-192799
      - Incremental-Snapshot-192809
      - Incremental-Snapshot-192819

This feature will flatten the directory structure and coalesce all the snapshots under same directory:

v1
  - Full-Snapshot-revision-1
  - Incremental-Snapshot-revision-6-1 (Format- Incremental-Snapshot-revision-<Revision Number After Last Operation>-<Revision Number Before First Operation>)
  - Incremental-Snapshot-revision-12-6
  - Incremental-Snapshot-revision-14-12
  - Incremental-Snapshot-revision-18-14
  - Full-Snapshot-revision-18
  - Incremental-Snapshot-revision-22-18
  - Incremental-Snapshot-revision-27-22
  - Incremental-Snapshot-revision-32-27
  - Incremental-Snapshot-revision-38-32
  - Full-Snapshot-revision-38
  - Incremental-Snapshot-revision-41-38
  - Incremental-Snapshot-revision-43-41
  - Incremental-Snapshot-revision-48-43
  - Incremental-Snapshot-revision-52-48

This reorganization will make backup directory look simpler and easier to work with compaction.

Refer: gardener/etcd-druid#88

@abdasgupta abdasgupta added the kind/enhancement Enhancement, improvement, extension label Feb 24, 2021
@amshuman-kr amshuman-kr added this to the v0.13.0 milestone May 20, 2021
@abdasgupta
Copy link
Contributor Author

Addressed here #301 . Closing it as the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants