Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use the config file for configuration #201

Closed
3 tasks
swapnilgm opened this issue Sep 12, 2019 · 1 comment · Fixed by #208
Closed
3 tasks

[Feature] Use the config file for configuration #201

swapnilgm opened this issue Sep 12, 2019 · 1 comment · Fixed by #208
Labels
area/dev-productivity Developer productivity related (how to improve development) component/etcd-backup-restore ETCD Backup & Restore exp/beginner Issue that requires only basic skills kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension platform/all priority/3 Priority (lower number equals higher priority)

Comments

@swapnilgm
Copy link
Contributor

Feature (What you would like to be added):

  • Introduce new flag --config-file which accepts the config file path.
  • Use this json/yaml config file to configure etcd-backup-restore server.
  • Also, centralise the validation for all flags

Motivation (Why is this needed?):
Currently there are too many flags for etcdbrctl server command. Configuring each flag on for command lengthens the command line drastically. Instead its better to have it in single config file with section for different correlated flags.

Approach/Hint to the implement solution (optional):

@swapnilgm swapnilgm added kind/enhancement Enhancement, improvement, extension area/dev-productivity Developer productivity related (how to improve development) component/etcd-backup-restore ETCD Backup & Restore exp/beginner Issue that requires only basic skills kind/api-change API change with impact on API users platform/all priority/normal status/accepted Issue was accepted as something we need to work on labels Sep 12, 2019
@amshuman-kr
Copy link
Collaborator

👍 for https://github.com/spf13/viper.

@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Nov 11, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jan 11, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Mar 13, 2020
@ghost ghost removed lifecycle/stale Nobody worked on this for 6 months (will further age) status/accepted Issue was accepted as something we need to work on labels Mar 24, 2020
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) component/etcd-backup-restore ETCD Backup & Restore exp/beginner Issue that requires only basic skills kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension platform/all priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants