Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoot list is empty / Websocket issue #449

Closed
petersutter opened this issue Sep 5, 2019 · 4 comments · Fixed by #486
Closed

Shoot list is empty / Websocket issue #449

petersutter opened this issue Sep 5, 2019 · 4 comments · Fixed by #486
Assignees
Labels
component/dashboard Gardener Dashboard effort/1d Effort for issue is around 1 day kind/bug Bug

Comments

@petersutter
Copy link
Member

petersutter commented Sep 5, 2019

We have seen that the shoot list on production clusters sometimes does not show any clusters. The list appears empty, even though they can be fetched directly from the kube apiserver e.g. using kubectl.
Restarting the dashboard pod solves the problem temporarily.

We have seen that this issue starts to occur with mass disconnections of websockets, e.g. when the nginx ingress controller detects a configuration change and restarts it's backends.

I could reproduce the issue locally and websockets/ws#1617 (comment) is a pretty good description of what I saw in the debugger. The issue seems to be solved with ws 7.1.2.

There is already a PR on engine.io to upgrade to ws 7.1.2

@grolu
Copy link
Contributor

grolu commented Sep 25, 2019

socket.io 2.3.0 has been released 5 days ago. Can you verify that the fix is included and solves the issue @petersutter

@grolu grolu added component/dashboard Gardener Dashboard kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 25, 2019
@petersutter
Copy link
Member Author

The fix is part of engine.io 3.4.0.
But the socket.io release contains engine.io 3.3.1 -> so no, unfortunately not yet within the latest socket.io release

@grolu
Copy link
Contributor

grolu commented Oct 25, 2019

still no new release as of today

@grolu
Copy link
Contributor

grolu commented Nov 4, 2019

re-checked, actually engine.io 3.4.0 is part of socket.io 2.3 so updating the dependency will solve the issue. @petersutter will take care.

@gardener-robot gardener-robot added effort/1d Effort for issue is around 1 day and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard Gardener Dashboard effort/1d Effort for issue is around 1 day kind/bug Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants