Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

introduce new packages #479

Open
andrei-panov opened this issue Dec 2, 2020 · 1 comment
Open

introduce new packages #479

andrei-panov opened this issue Dec 2, 2020 · 1 comment
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@andrei-panov
Copy link
Contributor

Hi all,
I want to discuss a generic question about gardenctl packages.
Currently there only one global package cmd with a very global scope. What you thinking about to introduce packages like this:

subcmd\
  kubectl\
  aws\
  hermesctl\

It will increase testability, reduce scope, make refactoring simpler, will allow us to use the same packages for testing (currently we use cmd_test and can’t test non-public methods), and as a side effect will let you control our dependencies graph better in terms that gardenctl itself will depend (in the code) on hermesctl but not another way around.
I’m not sure, but I suspect Target used everywhere and everything depends on it.

In the future, it will let us reuse these submodules independently in other projects?!

@neo-liang-sap
Copy link
Contributor

Nice proposal, i would suggest we cleanup all existing opening PRs, fix existing bugs (at least bugs we consider critical) in backlog, then we can start this refactor.
Let's discuss this in detail in next week planning mtg.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 22, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants