Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

func getTargetMapInfo(targetReader TargetReader) doesn't return namespace info #469

Open
neo-liang-sap opened this issue Nov 26, 2020 · 2 comments
Assignees
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@neo-liang-sap
Copy link
Contributor

Describe the bug
func getTargetMapInfo(targetReader TargetReader) doesn't return namespace info

To Reproduce
1.target a garden/seed/namespace
2.invoke getTargetMapInfo() function
3.no namepsace info included, other information garden,project,seed,shoot,shootTechnicalID are included

Expected behavior
namespace info should also be included

Screenshots
https://github.com/gardener/gardenctl/blob/master/pkg/cmd/miscellaneous.go#L270
image

Gardenctl Version (please complete the following information):
latest in master

Additional context

@jguipi jguipi self-assigned this Dec 4, 2020
@jguipi
Copy link
Contributor

jguipi commented Dec 4, 2020

I ran the test on my side and seems like I can see the namespace
image
And the output was :
image
As you can see the shootTechnicalID (the namespace) is present.

@neo-liang-sap
Copy link
Contributor Author

neo-liang-sap commented Dec 5, 2020

Hi @jguipi ,
Thanks for looking into this, my original expectation is when we have such a target

gardenctl get target
target:
- kind: garden
  name: dev
- kind: project
  name: sretestneo
- kind: shoot
  name: neo-test-ar
- kind: namespace
  name: kube-system

getTargetMapInfo could return sth including kube-system.

However i don't have strong opinion to implement this, if you consider current design is OK feel free close this issue.

Thanks!
-Neo

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 22, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants