Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach packages to find and use GMP in more cases (and possibly also other homebrew packages) #5678

Closed
5 of 6 tasks
fingolfin opened this issue Mar 17, 2024 · 1 comment
Closed
5 of 6 tasks
Labels
topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Milestone

Comments

@fingolfin
Copy link
Member

fingolfin commented Mar 17, 2024

For GAP itself we taught it to look for Homebrew installed package versions in PR #5214 / commit c091cba.

We also introduced GMP_PREFIX into sysinfo.gap for packages that would like to know where GAP found GMP. This is already being used by nq (see gap-packages/nq#24).

Relevant packages (from a run of BuildPackages.sh on my mac with GAP 4.13.0):

In addition, the following packages might benefit from finding Homebrew:

  • CddInterface: homebrew package cddlib actually it already checks for Homebrew, nice
  • ZeroMQInterface: homebrew package zmq

Off-topic, but vaguely related: passing --with-gaproot to the configure script of simpcomp leads to WARNING: unrecognized options: --with-gaproot -- perhaps that configure script can be modified to ignore that option. Or else we finally add a proper mechanism for detecting what a given package needs in order to build it, instead of "guessing" that we should run configure and make with certain arguments depending on various conditions...

@fingolfin fingolfin added the topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker) label Mar 17, 2024
@fingolfin fingolfin added this to the GAP 4.14.0 milestone Oct 13, 2024
@fingolfin
Copy link
Member Author

This is resolved to my satisfaction. Only float remains to be changed, and I filed an issue there, so if anyone runs into this, or is interested in working on this, I can point them there. But I myself have no use for float so I won't be pushing for it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Projects
None yet
Development

No branches or pull requests

1 participant