-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make install should install gapmacro and friends #5630
Comments
Actually it was deliberate to not install those, the idea being that nobody should be using these files; package authors that still use them need to jump through extra hoops, but that's fine. I guess the one reason to have this is for distro packagers who for one reason or another prefer to rebuild GAP package manuals; for them I guess this would be convenient. But is this reason enough to do it? Hm |
How about people who want to update a GAP package that uses these tools? E.g. I stumbled upon this issue during the latest round of working on the latest ACE update - turns out that an otherwise perfect Gentoo GAP installation is not OK for this purpose. |
As was pointed out in #5627 we actually do install all these files, I just forgot about it. In any case: issues with packages are package issues. It is not the obligation of the core GAP team to ensure that development of individual packages that chose to use or stick with legacy technology is kept simple. We won't actively try to impede them, but in the end, it is up to each package to deal with this. Some of these packages have listed "The GAP Team" as maintainer. Which means we'll try to merge reasonable PRs, apply certain janitorial tweaks, and take care of releases (which includes rebuilding manuals). But this does not entail conversion of the manuals to GAPDoc nor other work to make building the documentation easier for some people. There is a trick one can use for most of these packages which I'll describe on the GH Discussion linked above, but that's about it. |
Ah, but later in that discussion it is pointed out that |
The problem of location of IMHO a proper I am not sure what else in |
Whatever is done, please keep in mind that the primary way of how GAP and GAP packages are developed must keep working -- and that is not using |
It's matter of adjusting environment variables to point to the right places, be it the in-tree building of the package, or the package using "make install" infrastructure, or something else. GAP's PackageManager can facilitate this. |
I'll happily review your PRs for all that, I laid out the ground rules. |
Currently
make install
does not install things fromdoc/
, such asdoc/gapmacro*.tex
,makeindex
, etc.As they are needed by many packages for their documentation, cf. e.g. #639, it's important that
make install
takes care of this.Distributions use
make install
to create GAP installations in particular (e.g. SageMath, Gentoo - see #5627 ) etc.The text was updated successfully, but these errors were encountered: