Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asinh/Acosh/Atanh have no methods for machine floats #3983

Closed
mohamed-barakat opened this issue Apr 24, 2020 · 3 comments · Fixed by #3986
Closed

Asinh/Acosh/Atanh have no methods for machine floats #3983

mohamed-barakat opened this issue Apr 24, 2020 · 3 comments · Fixed by #3986
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: kernel

Comments

@mohamed-barakat
Copy link
Member

Observed behaviour

gap> Asinh( 0. );
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Asinh' on 1 arguments at /Users/mo/software/gap/build/gap-4.11.0/lib/methsel2.g:249 called from
<function "HANDLE_METHOD_NOT_FOUND">( <arguments> )
 called from read-eval loop at *stdin*:11
type 'quit;' to quit to outer loop
brk>

Expected behaviour

gap> Asinh( 0. );
0.

Copy and paste GAP banner (to tell us about your setup)

 ┌───────┐   GAP 4.11.0 of 29-Feb-2020
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: x86_64-apple-darwin19.3.0-default64-kv7
 Configuration:  gmp 6.2.0, GASMAN, readline
 Loading the library and packages ...
 Packages:   AClib 1.3.2, Alnuth 3.1.2, AtlasRep 2.1.0, AutoDoc 2019.09.04, AutPGrp 1.10.2, Browse 1.8.8, CRISP 1.4.5, Cryst 4.1.23, CrystCat 1.1.9, CTblLib 1.2.2,
             FactInt 1.6.3, FGA 1.4.0, Forms 1.2.5, GAPDoc 1.6.3, genss 1.6.6, IO 4.7.0, IRREDSOL 1.4, LAGUNA 3.9.3, orb 4.8.3, Polenta 1.3.9, Polycyclic 2.15.1, PrimGrp 3.4.0,
             RadiRoot 2.8, recog 1.3.2, ResClasses 4.7.2, SmallGrp 1.4.1, Sophus 1.24, SpinSym 1.5.2, TomLib 1.2.9, TransGrp 2.0.5, utils 0.69
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
@mohamed-barakat mohamed-barakat changed the title Asinh/Acosh( 0. ) -> no 1st method found Asinh/Acosh( 0. ) -> no 1st choice method found Apr 24, 2020
@fingolfin fingolfin changed the title Asinh/Acosh( 0. ) -> no 1st choice method found Asinh/Acosh/Atanh and other floating point related operations have no methods Apr 26, 2020
@fingolfin fingolfin added good first issue Issues that can be understood and addressed by newcomers to GAP development kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: kernel labels Apr 26, 2020
@fingolfin fingolfin changed the title Asinh/Acosh/Atanh and other floating point related operations have no methods Asinh/Acosh/Atanh have no methods for machine floats Apr 26, 2020
@fingolfin
Copy link
Member

None of these are implemented for GAP machine floats. If somebody wanted to, it would rather easy to add support for them. Or use a float type from the float package which implements these.

Note that Atanh is also missing. I'd not be surprised if there were more missing.

@fingolfin
Copy link
Member

Turns out none of the hyperbolic functions are implemented. Nor the special functions Erf, Zeta and Gamma.

@mohamed-barakat
Copy link
Member Author

I saw them together with Asin and Acos listed in the documentation so and the latter worked, so I thought that they are implemented too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: kernel
Projects
None yet
2 participants