Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openbsd support: readline treatment #3426

Closed
dimpase opened this issue Apr 27, 2019 · 2 comments · Fixed by #3428
Closed

openbsd support: readline treatment #3426

dimpase opened this issue Apr 27, 2019 · 2 comments · Fixed by #3428
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system

Comments

@dimpase
Copy link
Member

dimpase commented Apr 27, 2019

Observed behaviour

the default readline on openbsd is version 4 (the last LGPL version, I guess), and it lacks rl_bind_keyseq.
Thus, linking bails out with an undefined ref to it.

Expected behaviour

A minimal guard against this should have a test for rl_bind_keyseq. To actually get it all
working, one should use libereadline from /usr/local.
I'll send a PR to fix this, or at least to test for rl_bind_keyseq.
This was referenced Apr 29, 2019
Merged
Closed
@dimpase
Copy link
Member Author

dimpase commented Apr 29, 2019

There are 6 test failures in testinstall on OpenBSD, all related "\377" being printed as <FF>, so one sees

# Expected output:
"\377"
# But found:
"<FF>"

It's similar to #3152 and #2194, and gap-system/homebrew-gap#2

@wucas wucas added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system labels Jul 30, 2019
@dimpase
Copy link
Member Author

dimpase commented Nov 25, 2019

one can set LC_CTYPE=en_US.UTF-8 for a fix.
gap-system/homebrew-gap#2 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GNU readline detection on OpenBSD, and make the configure test for it more robust dimpase/gap
2 participants
@dimpase @wucas