Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functions in blister.c ignore mutability #3393

Closed
wilfwilson opened this issue Apr 6, 2019 · 0 comments · Fixed by #3392
Closed

Some functions in blister.c ignore mutability #3393

wilfwilson opened this issue Apr 6, 2019 · 0 comments · Fixed by #3392
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them topic: kernel

Comments

@wilfwilson
Copy link
Member

wilfwilson commented Apr 6, 2019

(Resolving this issue should wait until #3385 and #3391 are merged, so that the whole file can be done at once by adding the appropriate RequireMutable calls.)

As pointed out initially by @fingolfin in #3385 (comment):

...most other functions in [blister.c] also lack [mutability checks] :-/, e.g. FuncUNITE_BLIST. So I'd also be fine with accepting this "bug" in this PR for now, and then follow it up soon with another PR which adds the missing RequireMutable calls to all blister.c functions, together with test cases. And then we put that as a "wrong result" bug fix into the release notes, or so.

Here one of the instances of this bug in live action:

gap> l1:=MakeImmutable(ListWithIdenticalEntries(10,true));
[ true, true, true, true, true, true, true, true, true, true ]
gap> l2:=MakeImmutable(ListWithIdenticalEntries(10,false));
[ false, false, false, false, false, false, false, false, false, false ]
gap> UniteBlist(l2, l1);
gap> l2;
[ true, true, true, true, true, true, true, true, true, true ]
@wilfwilson wilfwilson added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: kernel labels Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them topic: kernel
Projects
None yet
1 participant