From dc5bfbe1c4b038b0e82b7374477e65f3f9dedbe0 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 21 Feb 2018 17:14:36 +0100 Subject: [PATCH] Don't rely on hidden impls in certain method installations --- lib/ghom.gd | 2 +- lib/grppcatr.gi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ghom.gd b/lib/ghom.gd index 5348737cadd..06fede6b350 100644 --- a/lib/ghom.gd +++ b/lib/ghom.gd @@ -273,7 +273,7 @@ InstallAttributeMethodByGroupGeneralMappingByImages := [ IsGroupGeneralMappingByAsGroupGeneralMappingByImages ], 0, hom -> attr( AsGroupGeneralMappingByImages( hom ) ) ); InstallMethod( attr, "get delayed set attribute values", true, - [ HasMappingOfWhichItIsAsGGMBI ], + [ IsGroupGeneralMapping and HasMappingOfWhichItIsAsGGMBI ], SUM_FLAGS-1, # we want to do this before doing any calculations function(hom) hom:=MappingOfWhichItIsAsGGMBI( hom ); diff --git a/lib/grppcatr.gi b/lib/grppcatr.gi index 067c4611e89..cc1f58a6eb4 100644 --- a/lib/grppcatr.gi +++ b/lib/grppcatr.gi @@ -675,7 +675,7 @@ end); #M GeneratorsSmallest() ## InstallMethod(GeneratorsSmallest,"group of pc words which is full family", - true, [HasFamilyPcgs],0, + true, [IsGroup and HasFamilyPcgs],0, function(G) local pcgs,gens,U,e,i,j,pa,ros,smallpcgs,exp;