Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on README.md #72

Open
cdwensley opened this issue Nov 17, 2020 · 2 comments
Open

Comments on README.md #72

cdwensley opened this issue Nov 17, 2020 · 2 comments

Comments

@cdwensley
Copy link

Having had no end of trouble releasing v1.18 of XModAlg, this document has been a great help.

(1) The release process (extended version) 7.
I found that I had to include --token ...... here.

(2) The release process (extended version) 9.
My problem with 'git push' was that, with XModAlg, my master points to cdwensley/xmodalg while upstream points to gap-packages/xmodalg. Eventually discovered that 'git push -f upstream' appeared to work. So maybe a comment here that a remote may need to be added to 'git push'?

@fingolfin
Copy link
Member

@cdwensley I am really sorry that you (once again) had such big trouble :-(. Did the emails by @alex-konovalov and me help any?

Regarding (1): well, that is one way to deal with the token; there are others, as described in section "GitHub access token". So I am loath to mention --token specifically (e.g. I never use that, for security reasons, as it means my access token ends up in the bash history file). However, perhaps it'd help if at the start of that section there was a reminder that all steps below require an access token to be set up?

Also, perhaps the very first thing the script should do is to probe for the token and then also test it (by doing something that uses the token to read something or so).

Regarding (2): I agree that there should be more of an explanation. Also, PR #71 is related.

@cdwensley
Copy link
Author

Yes - as always you and Alex are a great help.
The problems I encountered were mostly of my own making.
There's usually such a long period of time between making releases that I forget a lot of what happens - despite taking careful printouts from time to time.
The section "GitHub access token" has appeared too formidable in the past, but I have worked through it today and will find out how successful that has been when I next release XMod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants