Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user if tag already exists (instead of requiring --force or manual cleanup) #50

Open
fingolfin opened this issue Nov 30, 2017 · 1 comment

Comments

@fingolfin
Copy link
Member

When there is a problem while running release, it often happen that the version tag (say, v1.2.3) was already created. If one then has to change history to resolve the problems (by adding commits, or modifying existing commits), the tag doesn't point at HEAD anymore, which causes release to abort with an error.

So to resume the release process, one needs to either use --force or manually delete or move the bad tag.

Instead, we could show a prompt to the user, something like "the tag v1.2.3 already exists on commit != HEAD. Shall I force update it [y/N]". If you just press return, it aborts.

@olexandr-konovalov
Copy link
Member

I came across this and was deleting the tag manually. Good idea to make this more user-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants