Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't unpickle matrix groups with no generators #92

Open
ChrisJefferson opened this issue Dec 3, 2020 · 0 comments
Open

Can't unpickle matrix groups with no generators #92

ChrisJefferson opened this issue Dec 3, 2020 · 0 comments

Comments

@ChrisJefferson
Copy link
Member

In GAP, we can make groups with no generators, so calling Group(GeneratorsOfGroup(g)) doesn't work. The fix is to pass the identity of g as the second argument of 'Group'.

I've fixed this for permutation groups, but not for matrix groups, as nothing simple seems able to fix It:

  • The way the pickling is set up, I need the group before I know the dimension and field.

  • Passing in a "fake" list of generators which contains the identity is also tricky.

We could just make a fresh matrix group where "GeneratorsOfGroup" won't return nothing, or change how we pickle them so we always pass the identity in (changing the name of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant