Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken method in Job class #2109

Closed
egede opened this issue Feb 13, 2023 · 1 comment · Fixed by #2119
Closed

Broken method in Job class #2109

egede opened this issue Feb 13, 2023 · 1 comment · Fixed by #2119

Comments

@egede
Copy link
Member

egede commented Feb 13, 2023

The method _outputfieldCopyable in the Job class is manifestly broken as it doesn't return anything and has no side effects. So the method should just be removed.

A bit of care should be taken as it is used twice in the schema of the Job class. These two places will have None assigned where in principle a bool is expected. I think that False can just be assigned instead.

@mesmith75
Copy link
Contributor

mesmith75 commented Feb 23, 2023

gnore this - I see what has happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants