Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 64bit compliant #2

Merged
merged 4 commits into from
Sep 5, 2017
Merged

make 64bit compliant #2

merged 4 commits into from
Sep 5, 2017

Conversation

ken3
Copy link
Contributor

@ken3 ken3 commented Sep 1, 2017

If pcf2bdf is built and run on LP64 environment, int32 value can be wrong.
Why int32 is typedef-ed as long? It would be better to typedef int32 as int.

--- jiskan24.bdf.org 2017-09-01 19:16:59.241457019 +0900
+++ jiskan24.bdf 2017-09-01 19:08:13.041455456 +0900
@@ -21,7 +21,7 @@
CHARSET_REGISTRY "JISX0208.1983"
CHARSET_ENCODING "0"
WEIGHT 10
-X_HEIGHT 4294967295
+X_HEIGHT -1
QUAD_WIDTH 24
DEFAULT_CHAR 8481
FONT_DESCENT 2

@ganaware
Copy link
Owner

ganaware commented Sep 3, 2017

Thank you for your request.
Your request contains non-essential modifications about braces after "if".
Please include essential modifications only.

(Now I think it is bad habit to omit braces after "if", but my 15-years-younger self liked to omit them.)

@ken3
Copy link
Contributor Author

ken3 commented Sep 3, 2017

OK, I reverted if-parentheses.
I also fixed version comparison issue. See following:

pcf2bdf.cc: In function 'int main(int, char**)':
pcf2bdf.cc:622:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (version != make_int32(1, 'f', 'c', 'p'))
^

@ken3
Copy link
Contributor Author

ken3 commented Sep 3, 2017

rebased.

@ganaware ganaware merged commit 0d5d72e into ganaware:master Sep 5, 2017
@ganaware
Copy link
Owner

ganaware commented Sep 5, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants