Fails if XML file other than NUnit format is output to artifactsPath

[nowsprinting]

Bug description

Fails if XML file other than NUnit format is output to artifactsPath.

How to reproduce

Test outputs a file with a ".xml" extension other than the NUnit format.

Expected behavior

Ignore non-test result XML files.

Additional details

unity-test-runner/src/model/results-check.ts

Lines 21 to 28 in 05a00ef

	await Promise.all(
	files.map(async filepath => {
	if (!filepath.endsWith('.xml')) return;
	core.info(`Processing file ${filepath}...`);
	const fileData = await ResultsParser.parseResults(path.join(artifactsPath, filepath));
	core.info(fileData.summary);
	runs.push(fileData);
	}),

[GabLeRoux]

@coderabbitai, please review the file located at src/model/results-check.ts. There is an issue where files with a “.xml” extension, not in NUnit format, are causing errors when processed. Can you suggest a fix for this?

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@GabLeRoux, I see the issue in src/model/results-check.ts. The script processes all .xml files in the artifactsPath directory, assuming they are in NUnit format. This leads to errors when non-NUnit .xml files are encountered.

To fix this, you can modify the code to handle parsing errors gracefully by wrapping the parsing logic in a try-catch block. Here's how you might adjust your code:

// Parse all results files
const runs: RunMeta[] = [];
const files = fs.readdirSync(artifactsPath);
await Promise.all(
  files.map(async filepath => {
    if (!filepath.endsWith('.xml')) return;
    core.info(`Processing file ${filepath}...`);
    try {
      const fileData = await ResultsParser.parseResults(path.join(artifactsPath, filepath));
      core.info(fileData.summary);
      runs.push(fileData);
    } catch (error) {
      core.warning(`Failed to parse ${filepath}: ${error.message}`);
      // Optionally handle the error or skip the file
    }
  }),
);

By adding the try-catch block around the parsing function, the script will log a warning and continue processing other files if a file isn't in the expected NUnit format.

Let me know if this helps!

🔗 Analysis chain

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Output the contents of src/model/results-check.ts
cat src/model/results-check.ts

Length of output: 4227

[nowsprinting]

Thanks!!