This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Add support for Strings claim #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gambol99
suggested changes
May 25, 2018
There was a problem hiding this comment.
Hi @stefan-improbable ... much appreciated!! .. I left just the one comment.
Also, any chance we can update the README as well please ..
| zap.String("email", user.email), | ||
| zap.String("resource", resourceURL), | ||
| } | ||
|
|
There was a problem hiding this comment.
given Claims is type Claims map[string]interface{} .. we could just and fail quick .. What do you think?
if _, found := user.claims[claimName]; !found {
r.log.Warn("the token does not have the claim", errFields...)
return false
}
There was a problem hiding this comment.
Yep, I've added the statement here.
|
@gambol99 I've added some info to README |
gambol99
approved these changes
May 25, 2018
|
cheers @stefan-improbable ... LGTM |
|
@gambol99 thanks for the quick review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #314