Fix URL parsing for Go 1.8. #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
changed the title
timoreimann
force-pushed
the
travis-go-1.8
branch
from
a9ac2db
to
929cca2
Compare
|
@gambol99 could you have a look please? Thanks! |
timoreimann
force-pushed
the
travis-go-1.8
branch
from
929cca2
to
3818ebb
Compare
The behavior changed in 1.8. See also the 1.8 release notes[1], this Go issue[2], and these examples[3]. [1]https://golang.org/doc/go1.8#minor_library_changes [2]golang/go#16822 [3]https://play.golang.org/p/EKOP85WqLd
|
LGTM 👍 |
jangie
pushed a commit
to jangie/go-marathon
that referenced
this pull request
May 6, 2017
The behavior changed in 1.8. See also the 1.8 release notes[1], this Go issue[2], and these examples[3]. [1]https://golang.org/doc/go1.8#minor_library_changes [2]golang/go#16822 [3]https://play.golang.org/p/EKOP85WqLd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Go 1.8 to the tested build environments.
We also fix our cluster URL parsing logic to adjust to the change in behavior for scheme-less URL parsing. In summary, a URL like
http://10.0.0.1:8080,10.0.0.2:8080would work in Go < 1.8 but fail in Go 1.8.See the related commit message description for details.