Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path quoting is haphazard and fragile #88

Open
natefoo opened this issue Nov 18, 2022 · 0 comments
Open

Path quoting is haphazard and fragile #88

natefoo opened this issue Nov 18, 2022 · 0 comments

Comments

@natefoo
Copy link
Member

natefoo commented Nov 18, 2022

Exposed by the Galaxy startup tests that use a space in the galaxy root pathname, we had some bugs with path handling, which are addressed in #87.

However, the quoting is a bit scattered and haphazard. Part of the issue is that we use the same format vars for multiple purposes, only some of which are going to be part of the command line, which (currently) is the only thing that should be quoted. The working dir option for both process managers should not be quoted, and neither should the log path for supervisor, since these are not interpreted by a shell. We quote the data dir because it's used in a command line but not elsewhere. We don't quote galaxy_root because it's not used in any command lines, etc.

So we probably need a more structured way to denote what needs to be quoted and what doesn't. The simplest and cleanest solution may be to just split the command line format vars from the rest of the format vars.

Also, the GxIT session map path and tusd_path probably still need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant