Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intent leaked after welcome wizard #86

Closed
RoadXY opened this issue Dec 13, 2015 · 3 comments
Closed

Intent leaked after welcome wizard #86

RoadXY opened this issue Dec 13, 2015 · 3 comments
Labels
bug

Comments

@RoadXY
Copy link
Contributor

RoadXY commented Dec 13, 2015

See gist here:
https://gist.github.com/RoadXY/c48b8ea1dccad3f943d1
@galadril galadril added the bug label Dec 14, 2015
@galadril
Copy link
Owner

Looks like same problem like #88

@RoadXY
Copy link
Contributor Author

RoadXY commented Dec 14, 2015

In my humble opinion? No :-)

In the PhoneConnectionUtil there is a method called stopReceiver which unregisters the broadcastreceiver (for receiving wifi ssid's) (line 57 in PhoneConnectionUtil)
On every stop of the mainactivity (line 138) it tries to unregister this broadcast receiver but it wasn't started/initialized.

This issues intent is leaked when WelcomePage3 is paused/stopped.

@galadril
Copy link
Owner

Think i've fixed these issues with the next version (please check)

galadril added a commit that referenced this issue Dec 14, 2015
@galadril
v0.1.152
d6a465c 
- #82 Orientation changed to allow landscape
- #86 Fix for Intent leaked after welcome wizard
- #88 Fix for Receiver not registered
- #63 latest version of Geofence dialog (by roadXY)
- #24 Added a helping wizard for new users
- #lots of other fixes!!
@galadril galadril mentioned this issue Dec 14, 2015
Merged
galadril added a commit that referenced this issue Dec 14, 2015
@galadril
v0.1.152
14949bd 
- #82 Orientation changed to allow landscape
- #86 Fix for Intent leaked after welcome wizard
- #88 Fix for Receiver not registered
- #63 latest version of Geofence dialog (by roadXY)
- #24 Added a helping wizard for new users
- #lots of other fixes!!
@RoadXY RoadXY mentioned this issue Dec 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RoadXY @galadril