Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More user-friendly ShaderLab compilation error message #2248

Open
Sway007 opened this issue Jul 18, 2024 · 0 comments
Open

More user-friendly ShaderLab compilation error message #2248

Sway007 opened this issue Jul 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request high priority High priority issue Rendering Rendering related functions shader Shader related functions
Milestone

Comments

@Sway007
Copy link
Member

Sway007 commented Jul 18, 2024

Is your feature request related to a problem? Please describe.
The compilation error message is still obscure to shader developer, it should be more clear and help quickly identify the error location.

Describe the solution you'd like

Stage A: only console, no visual interface.
message should contain the macro expanded code, and the error location, which includes the line and column number.

Stage B: in visual interface, e.g. VSCode ide.
The red wavy underline should appear under the specific range in the specific file where the error occurred.

@Sway007 Sway007 added enhancement New feature or request shader Shader related functions medium priority Medium priority issue labels Jul 18, 2024
@Sway007 Sway007 self-assigned this Jul 18, 2024
@Sway007 Sway007 added the Rendering Rendering related functions label Aug 20, 2024
@zhuxudong zhuxudong added high priority High priority issue and removed medium priority Medium priority issue labels Aug 22, 2024
@zhuxudong zhuxudong added this to the 1.4 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority High priority issue Rendering Rendering related functions shader Shader related functions
Projects
None yet
Development

No branches or pull requests

2 participants