change visibility of request in Provider<JsonRpcClient>

[ntrippar]

Motivation

I want to implement a custom MIddleware to call otterscan RPC calls on the node and self implemented ones, currently the request function on Provider<JsonRpcClient> is private, changing the function to public will allow me to create implementations like this one.

#[async_trait]
pub trait OtterScanMiddleware: Middleware {
    async fn get_api_level(&self) -> Result<U64, ProviderError> {
        self.provider().get_api_level().await.map_err(FromErr::from)
    }
}

#[async_trait]
impl<P: JsonRpcClient> OtterScanMiddleware for Provider<P> {
    async fn get_api_level(&self) -> Result<U64, ProviderError> {
        self.request("ots_getApiLevel", []).await
    }
}

Solution

change request function to pub

[mattsse]

I guess we can do that, even though this function is merely used as a wrapper around self.inner.request(method, params) with additional tracing.

However we're returning unreachable in Provider::inner 🤔

So I think we should make this change @gakonst

[gakonst]

agreed - good one