Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Remove limit on Filter #917

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

scrogson
Copy link
Contributor

Motivation

While building a CLI to decode logs I reached for the limit method on Filter in order to implement some sort of pagination. To my surprise, it does not seem to have any effect. Combing through the documentation for Alchemy and Infura, the entries for eth_getLogs do not appear to include any limit option.

After pinging @gakonst in telegram, he suggested I make a PR to remove this as it doesn't appear to be part of the JSON-RPC specification.

Solution

Removed the limit option from Filter.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst
Copy link
Owner

gakonst commented Feb 16, 2022

good catch

@gakonst gakonst merged commit 859af7e into gakonst:master Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants