This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While building a CLI to decode logs I reached for the
limit
method onFilter
in order to implement some sort of pagination. To my surprise, it does not seem to have any effect. Combing through the documentation for Alchemy and Infura, the entries foreth_getLogs
do not appear to include anylimit
option.After pinging @gakonst in telegram, he suggested I make a PR to remove this as it doesn't appear to be part of the JSON-RPC specification.
Solution
Removed the
limit
option fromFilter
.PR Checklist