This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Artifact ids #882
Merged
Artifact ids #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
suggested changes
Feb 8, 2022
ethers-solc/src/artifact_output.rs
Outdated
| @@ -15,6 +15,36 @@ use std::{ | |||
| path::{Path, PathBuf}, | |||
| }; | |||
|
|
|||
| /// Represents unique artifact metadata for identifying artifacts on output | |||
| #[derive(Debug, Clone)] | |||
There was a problem hiding this comment.
Also needs PartialEq Eq Hash so we can use them as keys
Closed
2 tasks
|
@mattsse I'm adding a multi-version compile test to this for adding versioned linking. I've found an issue in |
|
Worth pointing out that I'm not sure this is a regression since the same branch works ok with foundry locally. Possibly a config issue? I'm pretty sure I've dealt with those already tho. |
|
Good catch, you probably found an existing issue. But I think we can go ahead with it anyway? so let's ignore the what's missing to complete foundry-rs/foundry#662 ? |
gakonst
approved these changes
Feb 18, 2022
gakonst
added a commit
to lattejed/foundry
that referenced
this pull request
Feb 18, 2022
3 tasks
gakonst
added a commit
to lattejed/foundry
that referenced
this pull request
Feb 18, 2022
gakonst
added a commit
to lattejed/foundry
that referenced
this pull request
Feb 18, 2022
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Feb 18, 2022
* Added test_path method to TestFilter * Added path regex to test interface * Added source path filtering to MultiContractRunner * Updated test Filter and reorganiezed test_helpers * Updated tests to use new filter * Fixed test filter * Use new into_artifacts * Path filtering requires absolute path * Formatting * Fixed warnings * Minor refactoring * Minor refactoring * Bumped semver to 1.0.5 for dev compatibility with ethers-rs * Added passing test for foundry_utils::link * Renamed test * chore: bump ethers for latest artifacts update gakonst/ethers-rs#882 driveby fixes: gakonst/ethers-rs#930 gakonst/ethers-rs#928 Co-authored-by: Georgios Konstantopoulos <[email protected]>
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
* Added test_path method to TestFilter * Added path regex to test interface * Added source path filtering to MultiContractRunner * Updated test Filter and reorganiezed test_helpers * Updated tests to use new filter * Fixed test filter * Use new into_artifacts * Path filtering requires absolute path * Formatting * Fixed warnings * Minor refactoring * Minor refactoring * Bumped semver to 1.0.5 for dev compatibility with ethers-rs * Added passing test for foundry_utils::link * Renamed test * chore: bump ethers for latest artifacts update gakonst/ethers-rs#882 driveby fixes: gakonst/ethers-rs#930 gakonst/ethers-rs#928 Co-authored-by: Georgios Konstantopoulos <[email protected]>
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
* Added test_path method to TestFilter * Added path regex to test interface * Added source path filtering to MultiContractRunner * Updated test Filter and reorganiezed test_helpers * Updated tests to use new filter * Fixed test filter * Use new into_artifacts * Path filtering requires absolute path * Formatting * Fixed warnings * Minor refactoring * Minor refactoring * Bumped semver to 1.0.5 for dev compatibility with ethers-rs * Added passing test for foundry_utils::link * Renamed test * chore: bump ethers for latest artifacts update gakonst/ethers-rs#882 driveby fixes: gakonst/ethers-rs#930 gakonst/ethers-rs#928 Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattsse this is related to foundry-rs/foundry#662
This just adds in an
ArtifactIdand hasinto_artifactsreturn it.I think this warrants ongoing discussion, but I've continued that in the PR linked above.
(There are some unrelated warnings and errors here that I've left alone)
PR Checklist