Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(chain): add BSC networks to the is_legacy helper #843

Merged
merged 1 commit into from
Jan 29, 2022
Merged

feat(chain): add BSC networks to the is_legacy helper #843

merged 1 commit into from
Jan 29, 2022

Conversation

0xca11
Copy link
Contributor

@0xca11 0xca11 commented Jan 29, 2022

Motivation

BSC networks are a part of the Chain, but were still not used on the is_legacy
method.

Solution

Add the BSC networks to the is_legacy Chain method.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

mattsse
mattsse approved these changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
clippy failure unrelated

@gakonst gakonst merged commit 44499ae into gakonst:master Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xca11 @mattsse @gakonst