This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(ws): propagate deserialization errors upstream + infura quickfix #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infura streams notifications with jsonrpc all capitalized. This fails to deserialize on our end because serde expect a precise match ressembling the Notification jsonrpc field. Fixes gakonst#684.
gakonst
approved these changes
Jan 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Deserializing a poorly formatted
Incomingmessage over websocket fails silently. This is why #684 was mysteriously failing when using awssprovider from Infura. Infura streams back messages with an all capitalizedJSONRPCfield which serde chokes over when deserializing into aNotification.Solution
Propagate deserialization errors through
ClientError.I think it's fair to support Infura idiosyncrasies considering they're such a prominent provider. With that said, the stable solution is probably using something like
#[serde(case_insensitive)](see serde-rs/serde#1902) although this should come with an overhead. In the meantime, this fixes the issue for Infura wss users.PR Checklist