Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(solc): traverse nodes iteratively #800

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 17, 2022

Motivation

Nodes were traversed recursively which could Hit a SO on large repos, like https://github.com/fei-protocol/tribe-turbo

Solution

Use an iterator NodesIter instead that yields all nodes instead

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - it does seem like these SO's are hard to unit test, so guess the best way is to add such repos in the integration tests in upstream foundry, or add integration tests for ethers-solc itself

@gakonst gakonst merged commit 579311b into gakonst:master Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants