This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add ProjectCompileOutput::has_compiler_warnings
#773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Jan 7, 2022
ethers-solc/src/lib.rs
Outdated
Comment on lines
786
to
791
| if let Some(output) = self.compiler_output.as_ref() { | ||
| output.has_warning() | ||
| } else { | ||
| false | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if let Some(output) = self.compiler_output.as_ref() { | |
| output.has_warning() | |
| } else { | |
| false | |
| } | |
| } | |
| self.compiler_output.as_ref().map(|o|o.has_warning()).unwrap_or_default() |
|
Want me to change this one too? ethers-rs/ethers-solc/src/lib.rs Lines 776 to 782 in 418d54b |
|
sure! let's improve it consistently :) thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this part for #772