feat: support abi generated from forge

[thasarito]

Motivation

Binding generated by AbiGen which bind output of forge build throws this error #683

But it work If I change the format of ABI json to only be the content of abi

Solution

PR Checklist

• Added Tests
• Added Documentation
• Updated the changelog

[gakonst]

Hey - I think this does not exactly work? A few errors in CI - could you take another look?

[thasarito]

looks like https://github.com/thasarito/ethers-rs/blob/8c63eef62669e5a13a5adac44166f2348913310d/ethers-contract/ethers-contract-abigen/src/contract.rs#L159 breaks a lot of test.

Can you give me some direction how to fix this? @mattsse @gakonst

[mattsse]

looks like https://github.com/thasarito/ethers-rs/blob/8c63eef62669e5a13a5adac44166f2348913310d/ethers-contract/ethers-contract-abigen/src/contract.rs#L159 breaks a lot of test.

Can you give me some direction how to fix this? @mattsse @gakonst

abi parsing is a bit horrible rn:

• the ethabi::Contract type does not really deserialize to the same json object solc spits out, I noticed it omits some fields for the constructor.
• Also we currently have a system in place that handles human readable abi differently, instead of the json abi we parse the human readable abi during runtime as well, which is perhaps no longer necessary, I think

So how to mitigate this here:
short term is, update the abi_str only in this else branch, and use the RawAbi to deserialize it

ethers-rs/ethers-contract/ethers-contract-abigen/src/contract.rs

Lines 177 to 181 in 42647d6

	serde_json::from_str::<RawAbi>(&abi_str)
	.ok()
	.map(InternalStructs::new)
	.unwrap_or_default()
	};

[gakonst]

hey @thasarito - happy new year! any plans to get this over the line?

[thasarito]

hey @thasarito - happy new year! any plans to get this over the line?

I'm working on it but it might take a while.

[gakonst]

word - just checking! no rush.

[thasarito]

@gakonst

I checked to change the abi_str in case that it starts with {.