-
Notifications
You must be signed in to change notification settings - Fork 794
[draft] Add Optimism & OptimismKovan chains #737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mattsse @gakonst Ser, I'm sorry I marked this PR as a draft coz when I try to deploy contract via This line ethers-rs/ethers-providers/src/provider.rs Line 437 in e24117a
It turns out that the JSON-RPC response from Optimism is a bit different. Here is response from kovan
here is from optimism kovan:
Notice that there is no If
|
It seems that I need to enable legacy trx when deploying to optimism: ethers-rs/ethers-contract/src/factory.rs Lines 164 to 179 in e24117a
|
Yeah Optimism does not have 1559 enabled so you should use |
Motivation
I want to add Optimism verification support for foundry, but it turns out foundry depends on this package and optimism is not supported yet. This PR add support for Optimism network.
More information about Optimism:
Solution
There are two packages that need to be updated:
ETHERSCAN_API_KEY
on optimismPR Checklist