This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(abigen): support overloaded functions with different casing #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
changed the title
mattsse
force-pushed
the
matt/handle-case-sensitive-duplicate-calls
branch
from
67073c5 to
0844540
Compare
|
Instead of casing and suffixing _0/_1 etc., should we instead just maintain the same casing as the source function? I imagine it can be confusing to remember whether |
mattsse
force-pushed
the
matt/handle-case-sensitive-duplicate-calls
branch
from
c4ddc7e to
23adc4a
Compare
mattsse
force-pushed
the
matt/handle-case-sensitive-duplicate-calls
branch
from
23adc4a to
d3c4b47
Compare
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
… New users may not realize. (gakonst#650) Co-authored-by: Drake Evans <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #571
Solution
look for overloaded functions with different casing when deriving aliases
PR Checklist