This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
refactor!: make artifactoutput a trait #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Nov 14, 2021
| @@ -260,6 +277,28 @@ impl ProjectBuilder { | |||
| self | |||
| } | |||
|
|
|||
| /// Set arbitrary `ArtifactOutputHandler` | |||
| pub fn artifacts<A: ArtifactOutput>(self) -> ProjectBuilder<A> { | |||
There was a problem hiding this comment.
Interesting pattern to change the generic of a struct, hadn't thought about this before.
mattsse
force-pushed
the
matt/artifacts
branch
from
701f5c3 to
f408729
Compare
As discussed with @mattsse the abstraction here might not be super clean, so we should revisit this if we do not like it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improved artifacts handling in
Project::compileSolution
ArtifactOutputtraitArtifactfromProjectCompilerOutputwhether it's unchanged or compiled.ProjectCompileOutputa structPR Checklist