This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Fix RLP encoding of gas price #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Aug 27, 2021
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* Fetch code using etherscan api * Add chains * Add structops * Add cargo.lock * Formatting * Change logic * Remove unwraps * Fix lint * chore: fix missing import Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The gas price is an
Optionbecause of EIP-1559, and this encodes gas price as a list, leading to invalid RLP, see onbjerg/ethers-flashbots#11Solution
Use
rlp_optto correctly encode the gas price if it is set. I'm not sure if this is the best way to go about it since not setting a gas price by this point would then result in an empty field, but I guess it is also a logic error to arrive to this point without having the gas price set?