Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feature: signer using aws kms #358

Merged
merged 3 commits into from
Aug 1, 2021
Merged

feature: signer using aws kms #358

merged 3 commits into from
Aug 1, 2021

Conversation

prestwich
Copy link
Collaborator

@prestwich prestwich commented Aug 1, 2021 •
edited
Loading

Adds an AWS KMS signer to ethers-signers

Some notes:

  1. haven't found a mock KMS that supports ecdsa signing. So can't test this outside of a real aws account
  2. It is working with my AWS account
  3. added under the aws feature
  4. The utils functions are NOT for general consumption
  5. The public key is retrieved on instantiation. ergo, instantiation is async

TODO:

  • documentation
  • instantiation notes and examples

@prestwich prestwich added the enhancement New feature or request label Aug 1, 2021
@prestwich prestwich requested a review from gakonst August 1, 2021 20:06
gakonst
gakonst approved these changes Aug 1, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legendary

@gakonst gakonst merged commit 5382b5b into master Aug 1, 2021
@gakonst gakonst deleted the prestwich/aws-signer branch August 1, 2021 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @gakonst