This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feature: PendingTransaction returns Option #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some failing tests are related to changes in streaming tests. can someone with more context take a look? |
gakonst
force-pushed
the
prestwich/pending-tx-drops
branch
from
75130a6 to
8c2ae3c
Compare
gakonst
approved these changes
Jul 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #326
Solution
Option<TransactionReceipt>Noneis returned when the tx drops from the mempool without confirmingPendingTransactioninternals to prevent repeated cloning of the receiptPendingTransactionto handle theNonecase