Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat: add filter utility function #316

Merged
merged 3 commits into from
Jun 13, 2021
Merged

feat: add filter utility function #316

merged 3 commits into from
Jun 13, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 13, 2021

Motivation

Makes setting block ranges more convenient by adding a new function (select) to the Filter struct and convenient From impls.

Not sure about:

  • the name
  • whether to include From<U256> since at_block_hash does the same already.

Solution

gakonst
gakonst approved these changes Jun 13, 2021
View reviewed changes
ethers-core/src/types/log.rs Outdated Show resolved Hide resolved
ethers-core/src/types/log.rs Outdated Show resolved Hide resolved
mattsse and others added 2 commits June 13, 2021 19:22
@mattsse @gakonst
chore: typo
3e15d57 
Co-authored-by: Georgios Konstantopoulos <[email protected]>
@mattsse @gakonst
chore: typo
a732e58 
Co-authored-by: Georgios Konstantopoulos <[email protected]>
@gakonst gakonst merged commit 1dda336 into gakonst:master Jun 13, 2021
hanyunx pushed a commit to hanyunx/ethers-rs that referenced this pull request Jun 17, 2021
@mattsse @gakonst @hanyunx
feat: add filter utility function (gakonst#316)
bd61231 
* feat: add filter utility function

* chore: typo

Co-authored-by: Georgios Konstantopoulos <[email protected]>

* chore: typo

Co-authored-by: Georgios Konstantopoulos <[email protected]>

Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @gakonst