Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feature: Signature derives Copy trait #288

Merged
merged 2 commits into from
May 9, 2021
Merged

feature: Signature derives Copy trait #288

merged 2 commits into from
May 9, 2021

Conversation

prestwich
Copy link
Collaborator

@prestwich prestwich commented May 8, 2021 •
edited
Loading

derives Copy on Signature

Motivation

I'd like Signature to be Copy

Solution

Derive Copy

Drive-by change

Set network ID in signer in Celo tests

@prestwich prestwich requested a review from gakonst May 8, 2021 22:55
@prestwich prestwich force-pushed the prestwich/signature-copy branch from ea5cebe to 8fc6f6a Compare May 8, 2021 23:34
@prestwich prestwich force-pushed the prestwich/signature-copy branch from 8fc6f6a to 241e049 Compare May 8, 2021 23:46
@prestwich
Copy link
Collaborator Author

prestwich commented May 8, 2021 •
edited
Loading

Pretty sure the IPC test is an unrelated race condition?

@gakonst gakonst merged commit b014ac9 into master May 9, 2021
@gakonst gakonst deleted the prestwich/signature-copy branch May 9, 2021 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @gakonst