chore(deps): bump and use workspace dependencies #2222
Conversation
bad configuration
|
sorry need to bump versions to 2.0 everywhere |
| @@ -147,9 +165,6 @@ jobs: | |||
| - uses: Swatinem/rust-cache@v2 | |||
| - name: Check | |||
| run: cargo check --workspace --target wasm32-unknown-unknown | |||
| # TODO: [#2191](https://github.com/gakonst/ethers-rs/issues/2191) | |||
There was a problem hiding this comment.
hmm i forget why i removed that, it still is with the features
| #[cfg(target_arch = "wasm32")] | ||
| wasm_timer::Delay::new(next_backoff) | ||
| .await | ||
| .map_err(|_| RetryClientError::TimerError)?; | ||
| futures_timer::Delay::new(next_backoff).await; |
There was a problem hiding this comment.
is this correct? if so, should we just use it in both cases?
| @@ -70,7 +70,7 @@ pub(crate) fn take_solc_installer_lock() -> std::sync::MutexGuard<'static, ()> { | |||
| /// A list of upstream Solc releases, used to check which version | |||
| /// we should download. | |||
| /// The boolean value marks whether there was an error accessing the release list | |||
| #[cfg(all(feature = "svm-solc"))] | |||
| #[cfg(all(feature = "svm-solc", not(target_arch = "wasm32")))] | |||
There was a problem hiding this comment.
Does anything in ethers-solc work inside of WASM, given it's calling the binary? Should we just make the crate not compile with ethers-rs if wasm is not configured?
| @@ -1,10 +1,14 @@ | |||
| [package] | |||
There was a problem hiding this comment.
Can we make cargo release not go over the examples crates if possible? Right now it thinks all the examples should be published
There was a problem hiding this comment.
doesn't publish = false do the trick? What's the command you run to release
| [package] | ||
| name = "ethers" | ||
| authors = ["Georgios Konstantopoulos <[email protected]>"] | ||
| readme = "../README.md" | ||
| description = "A complete Ethereum and Celo Rust library" |
There was a problem hiding this comment.
Are we OK with pulling ethers back down a directory? I initially had pulled it up to surface the examples, but seems fine now given we have separate examples crates
There was a problem hiding this comment.
I think so, also this way it doesn't pull in every folder like .github when packaging the ethers crate for release
Motivation
Closes #1963
Solution
See commit log
PR Checklist