This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
chore(etherscan): add cloudflare captcha error #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't we early return if the response's status code is bad? or is that also inconsistent |
|
so less specific error variant and just, NotOk? I don't think this is more useful. |
mattsse
force-pushed
the
matt/new-cloudflare-error
branch
from
7c5f64d to
51b1022
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
new cloudflare error unlocked.
this supports a new cloudflare error variant that occurs when cloudflare asks for a captcha upon an API request.
discovered here https://github.com/foundry-rs/foundry/actions/runs/4091046786/jobs/7054872187
Solution
PR Checklist