This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Fix Signature Recovery Id & expose verify function
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
force-pushed
the
gakonst/signature-verify
branch
from
2967475 to
a906fa0
Compare
u8 would not work if a large chain_id was used
gakonst
force-pushed
the
gakonst/signature-verify
branch
from
a906fa0 to
afc525b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The recovery_id was stored as a u8. This means that EIP-155 signatures with larger chain_id's would fail (since we'd overflow the variable).
Solution
Storing
vas u64 fixes this.Also exposes a
Signature.verifyfunction, as per @tuxxy suggestion.