This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(providers): support personal account apis #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
* add personal_importRawKey and personal_unlockAccount
Rjected
force-pushed
the
personal-import-account
branch
from
b2f6914 to
050daa8
Compare
|
rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In reth we are using a clique geth to perform end to end testing. To produce blocks, clique requires that geth manage a clique signing key. Geth needs the raw signing key, and must explicitly "unlock" (decrypt) the key in order to start mining.
Solution
Add support for the following
personalAPIs:personal_importRawKeypersonal_unlockAccountThe
personalnamespace is also enabled inGeth. Ainsecure_unlockmethod is added so we can usepersonal_unlockAccountwith open HTTP RPCs.PR Checklist