Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat: add support for EIP-712 typed data #1510

Merged
merged 8 commits into from
Jul 27, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 25, 2022

Motivation

foundry-rs/foundry#2458

add support for eth_signTypedData_v4

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 25, 2022

the example in foundry-rs/foundry#2458 doesn't match hardhat's response. unsure why yet

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 26, 2022

tracked down two issues:

  • remove array tails when building the type hash...
  • correctly encode fixedbytes

this should be good to merge, added test coverage for

  • custom types
  • custom arrays
  • recursive types

ethers-core/Cargo.toml Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants