Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(abigen): remove redundant index adjustment for many overloads #1419

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 27, 2022

Motivation

removes a redundant index increase when deriving aliases for overloaded functions

prior to this, many overloaded function would be expanded to

        HEVMCalls::ToString0(inner) =>,
        HEVMCalls::ToString2(inner) => ,
        HEVMCalls::ToString3(inner) => ,
        HEVMCalls::ToString4(inner) => ,

as seen here https://github.com/foundry-rs/foundry/pull/2127/files

Solution

removes the index increase that turned out to be redundant.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst gakonst merged commit f17f900 into gakonst:master Jun 27, 2022
@vicente-noriega

This comment was marked as spam.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants