Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

TypedTransaction methods into builder style #1414

Merged
merged 1 commit into from
Jun 26, 2022
Merged

TypedTransaction methods into builder style #1414

merged 1 commit into from
Jun 26, 2022

Conversation

h00p30
Copy link
Contributor

@h00p30 h00p30 commented Jun 24, 2022

Motivation

#1400

Solution

Make methods like set_from() return &mut Self in TypedTransaction

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

mattsse
mattsse approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@gakonst gakonst merged commit 94c7559 into gakonst:master Jun 26, 2022
@mattsse mattsse mentioned this pull request Aug 18, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h00p30 @mattsse @gakonst