Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat: impl rlp encodable for log and receipt #1153

Merged
merged 1 commit into from
Apr 18, 2022
Merged

feat: impl rlp encodable for log and receipt #1153

merged 1 commit into from
Apr 18, 2022

Conversation

roynalnaruto
Copy link
Collaborator

Motivation

rlp::Encodable trait not implemented for Log and TransactionReceipt.

Solution

Implement the trait for the two types, reference:

  1. https://github.com/ethereum/go-ethereum/blob/master/core/types/receipt.go#L84-L90
  2. https://github.com/ethereum/go-ethereum/blob/master/core/types/log.go#L67-L71

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst gakonst merged commit 45cce0f into gakonst:master Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roynalnaruto @gakonst @mattsse