This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 791
feat(solc): optimize output selection in cache mode #1029
Merged
gakonst
merged 26 commits into
gakonst:master
from
mattsse:matt/prune-unnecessary-ouput
Mar 15, 2022
Merged
feat(solc): optimize output selection in cache mode #1029
gakonst
merged 26 commits into
gakonst:master
from
mattsse:matt/prune-unnecessary-ouput
Mar 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Mar 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far so good - excited about this, will be even better on larger repos
gakonst
approved these changes
Mar 15, 2022
Comment on lines
+92
to
+93
/// `{ "*": { "*": [ "*" ], "": [ | ||
/// "abi","evm.bytecode","evm.deployedBytecode","evm.methodIdentifiers"] } }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit formatting here prob pretty print better
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1009
Solution
only select output for files that are actually dirty and select nothing for other files that are pulled in by dirty files.
Some preliminary testing on https://github.com/maple-labs/loan/releases/tag/v3.0.0-beta.0
cached and modified MapleLoan.t.sol:
with this PR:
note the 30 files are 1 dirty + 29 imported. There's currently no easy way to fix this as the total number of source files in the CompilerInput is reported
current master
Todo
PR Checklist