This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Fix websocket connection request #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tungstenite 0.17 a change was introduced considering the logic of `IntoClientRequest`. When using this trait on a `HttpRequest` it just uses the request without any changes to inititate the websocket connection. This makes it necessary for the consumer of the api to supply the correct http headers for initiating a websocket connection when using `IntoClientRequest` on `HttpRequest`. This commit adapts the logic in `connect_with_auth` to this new behavior.
gakonst
approved these changes
Mar 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tungstenite 0.17 a change was introduced considering the logic of
IntoClientRequest. Look hereWhen using this trait on a
HttpRequestit justuses the request without any changes to initiate the websocket
connection. This makes it necessary for the consumer of the api to supply the
correct http headers for initiating a websocket connection when using
IntoClientRequestonHttpRequest.This commit adapts the logic in
connect_with_authto this newbehavior.